Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3rd use environment vars to workaround issues #94

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: 3rd use environment vars to workaround issues #94

merged 1 commit into from
Feb 1, 2024

Conversation

noelmcloughlin
Copy link
Contributor

@noelmcloughlin noelmcloughlin commented Feb 1, 2024

This PR does the following:

  • improved variable names and better documentation in config.env and makefile

  • introduce LINKML_ENVIRONMENT_FILE var for custom configuration location. For example to hide the file via .config.yaml or .config/generators.yaml or some other odd reason.

  • Add some logic to Makefile to use environment variables as action triggers

  1. set typescript environment variable (args) to trigger gen-typescript
  2. set java environment variable (args) to trigger gen-java
  3. set owl environment variable (args) if rdfs is needed (Parm 'owl: {metadata_profile: rdfs} in config.yaml error linkml#1453)

This PR replaces #69

@noelmcloughlin noelmcloughlin marked this pull request as draft February 1, 2024 02:04
@noelmcloughlin noelmcloughlin changed the title feat: use environment varibles to solve issues feat: use environment varibles to workaround issues Feb 1, 2024
@noelmcloughlin noelmcloughlin marked this pull request as ready for review February 1, 2024 13:04
@noelmcloughlin noelmcloughlin changed the title feat: use environment varibles to workaround issues feat: 3rd use environment vars to workaround issues Feb 1, 2024
@noelmcloughlin
Copy link
Contributor Author

See also #95 and comments in #57

@pkalita-lbl pkalita-lbl merged commit 62dfecd into linkml:main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants